-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tensorflow
: Add missing members to the tensorflow.keras.layers
module.
#11333
tensorflow
: Add missing members to the tensorflow.keras.layers
module.
#11333
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
9e8a90c
to
7e2db33
Compare
This comment has been minimized.
This comment has been minimized.
08c3a39
to
52e0d83
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
@hmc-cs-mdrissi I've tried to add the Edit: after spending a bunch of time trying to make CI pass without success, I've removed |
FYI this has a merge conflict now. |
c226323
to
9cd6010
Compare
This comment has been minimized.
This comment has been minimized.
[pre-commit.ci] auto fixes from pre-commit.com hooks Move some layers to keras.layers.preprocessing fix: fix imports
5ee5f57
to
a05968f
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
a05968f
to
35e3b72
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
f9685a2
to
b17c74a
Compare
attempt to fix MultiHeadAttention's __call__
b17c74a
to
35056a7
Compare
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
@JelleZijlstra It seems like pytype is causing CI to fail again. Is it happening in other PRs ? |
This failure looks different than before. Presumably it's triggered by commit 37c668b, since the one before that is green. However, the failures on that commit (https://github.com/python/typeshed/actions/runs/7941246262/job/21683390603) also look different from those on the most recent commit (https://github.com/python/typeshed/actions/runs/7941516630/job/21683958032?pr=11333). @rchen152 I'm afraid I have to ping you again. |
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Looking. Sorry about all the weird pytype errors! |
I have a pytype fix out for review, but I'm out the rest of this week; I'll try to do a release first thing on Monday. |
Fixes a bug that affects typeshed's pytype_test. See python/typeshed#11333 for context. I wasn't able to write a test for this because it's triggered by some complicated combination of mutually dependent pyi files and mutually recursive aliases. PiperOrigin-RevId: 609414132
Ok, I think pytype is finally happy. |
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
But now there is a merge conflict. If you fix that, I can merge. |
@JelleZijlstra @rchen152 I merged main into the branch, but this caused pytype to fail again. |
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
@JelleZijlstra Is it because there's something wrong with the PR ? The PR doesn't use Looking at
|
Pytype errors can be somewhat opaque. I wouldn't be surprised if this PR affects DType in some indirect way. To check this further I tried to merge main into some of your other open PRs about tensorflow, but seems like GitHub is having an outage at the moment. |
Try doing this (remove the extra DType import in
Right now, pytype handles circular dependencies among pyi files in a rather ugly way, by just resolving names multiple times until everything is sorted. So tweaking the dependency structure can help with name resolution issues. |
Patch from this comment: python#11333 (comment)
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Some of the added stubs are taken from here.