Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "state" type annotations for tkinter "Canvas.create_*" methods #11257

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Fix "state" type annotations for tkinter "Canvas.create_*" methods #11257

merged 1 commit into from
Jan 8, 2024

Conversation

rdesparbes
Copy link
Contributor

Fixes #11256

@AlexWaygood AlexWaygood requested a review from Akuli January 7, 2024 14:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2024

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Akuli
Akuli approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The annotations probably ended up this way, because many widgets have a state option that accepts "active".

@Akuli Akuli merged commit db80484 into python:main Jan 8, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akuli Akuli Akuli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Canvas.create_*" methods have invalid type hints for the "state" parameter
2 participants
@rdesparbes @Akuli