Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ruff for from __future__ import annotations checks #10910

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Oct 18, 2023

Suggestion to use Ruff for faster and smarter from __future__ import annotations checks

- uses: actions/checkout@v4
- uses: chartboost/ruff-action@v1
with:
version: "0.0.292" # must match .pre-commit-config.yaml and requirements-test.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the version doesn't match. :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I got distracted and forgot to check for other locations after merging

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit 21fcd89 into python:main Oct 19, 2023
92 checks passed
@Avasam Avasam deleted the ruff-__future__.annotations branch October 19, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants