Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a lint forbidding PEP-570 syntax #10660

Merged
merged 4 commits into from
Sep 4, 2023
Merged

Add a lint forbidding PEP-570 syntax #10660

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
739e9d0
Add a lint forbidding PEP-570 syntax
AlexWaygood Sep 4, 2023
0b32fbb
make pyright happy
AlexWaygood Sep 4, 2023
cb8eff2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 4, 2023
57939de
be principled
AlexWaygood Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions tests/check_new_syntax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,29 @@ def visit_If(self, node: ast.If) -> None:
)
self.generic_visit(node)

class PEP570Finder(ast.NodeVisitor):
def __init__(self) -> None:
self.lineno: int | None = None

def _visit_function(self, node: ast.FunctionDef | ast.AsyncFunctionDef) -> None:
old_lineno = self.lineno
self.lineno = node.lineno
self.generic_visit(node)
self.lineno = old_lineno

visit_FunctionDef = visit_AsyncFunctionDef = _visit_function

def visit_arguments(self, node: ast.arguments) -> None:
if node.posonlyargs:
assert isinstance(self.lineno, int)
errors.append(
f"{path}:{self.lineno}: PEP-570 syntax cannot be used in typeshed yet. "
f"Prefix parameter names with `__` to indicate positional-only parameters"
)
self.generic_visit(node)

IfFinder().visit(tree)
PEP570Finder().visit(tree)
return errors


Expand Down