Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary forward refs in class definitions #10124

Merged
merged 1 commit into from
May 1, 2023

Conversation

AlexWaygood
Copy link
Member

Put superclass definitions before subclass definitions wherever possible, to improve readability. This addresses all the new F821 hits in PyCQA/flake8-pyi#364 (comment) (and I think it's worth doing whether or not that PR gets merged).

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra JelleZijlstra merged commit e816acf into python:main May 1, 2023
@AlexWaygood AlexWaygood deleted the fewer-forward-refs branch May 1, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants