Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove emoji stubs (not before May 2023) #8760

Closed
kkirsche opened this issue Sep 17, 2022 · 7 comments · Fixed by #10160
Closed

Remove emoji stubs (not before May 2023) #8760

kkirsche opened this issue Sep 17, 2022 · 7 comments · Fixed by #10160
Labels
stubs: removal Pending removal of third-party distributions

Comments

@kkirsche
Copy link
Contributor

kkirsche commented Sep 17, 2022

With carpedm20/emoji#166 merged using the stubs previously contributed to typeshed, the latest release now next release should include type hints. Seems 2.1.0 was tagged directly before type hints being merged.

@AlexWaygood AlexWaygood added the stubs: removal Pending removal of third-party distributions label Sep 17, 2022
@AlexWaygood AlexWaygood changed the title Remove emoji from typeshed Remove emoji stubs (not before ?) Sep 17, 2022
@AlexWaygood
Copy link
Member

As per our policy, we'll want to wait until the library has shipped with a py.typed file for at least six months before removing the stubs from typeshed, but this is great to hear! :)

@kkirsche
Copy link
Contributor Author

Emoji 2.1.0 was released on September 17, 2022.

https://pypi.org/project/emoji/2.1.0/

When in front of a computer, I'll confirm that it has the py.typed marker. If so, this should give us a date for when this should be removed.

I'll plan to file a separate issue for automated py.typed detection to gauge interest in this type of automation / integration.

@AlexWaygood
Copy link
Member

AlexWaygood commented Oct 12, 2022

I'll plan to file a separate issue for automated py.typed detection to gauge interest in this type of automation / integration.

Stubsabot already does that for us (see, e.g., #8746). If there's already been an emoji release that has a py.typed file, that indicates that there's a bug in stubsabot.

@AlexWaygood
Copy link
Member

There doesn't appear to be a bug in stubsabot. The master branch has the py.typed marker, but the latest release, 2.1.0, released on September 17, does not have the py.typed marker.

@hauntsaninja
Copy link
Collaborator

Probably a bug in emoji packaging

@Avasam
Copy link
Collaborator

Avasam commented Oct 14, 2022

It is a bug in emoji. The py.typed marker isn't added to the package carpedm20/emoji#239

@AlexWaygood
Copy link
Member

We now have a release with a py.typed file!

@AlexWaygood AlexWaygood changed the title Remove emoji stubs (not before ?) Remove emoji stubs (not before May 2023) Nov 1, 2022
sobolevn added a commit that referenced this issue May 9, 2023
AlexWaygood pushed a commit that referenced this issue May 9, 2023
Remove `emoji` stubs, refs #8760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stubs: removal Pending removal of third-party distributions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants