Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

[3.6] Remove unconditional error on async/await name usage #33

Merged
merged 1 commit into from
Mar 6, 2017

Conversation

ddfisher
Copy link
Collaborator

@ddfisher ddfisher commented Mar 6, 2017

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

  1. If you don't have an account on b.p.o, please create one
  2. Make sure your GitHub username is listed in "Your Details" at b.p.o
  3. If you have not already done so, please sign the PSF contributor agreement. The "bugs.python.org username " requested by the form is the "Login name" field under "Your Details".
  4. If you just signed the CLA, please wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  5. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@gvanrossum
Copy link
Member

LGTM. Love the irony of the bot's message, I think you can still merge (but maybe contact Gideon to see if there's a Dropbox contributor's agreement with the PSF on file).

@ddfisher
Copy link
Collaborator Author

ddfisher commented Mar 6, 2017

I'm pretty sure we checked that a while ago (and there was). Maybe someone needs to verify that for my account on bugs.python.org?

@gvanrossum
Copy link
Member

OK, I've set that flag for your account.

@ddfisher
Copy link
Collaborator Author

ddfisher commented Mar 6, 2017

Thanks! Double checked my email: yes Dropbox signed a CLA, and we should expect this to be covered.

@ddfisher ddfisher merged commit 5d5128f into master Mar 6, 2017
@ddfisher ddfisher deleted the remove-async-error branch March 6, 2017 20:27
tbbharaj pushed a commit to tbbharaj/typed_ast that referenced this pull request Dec 6, 2021
Use GET_SIZE macros to avoid unecessary second check
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants