Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PyUnicodeWriter API #95

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Add PyUnicodeWriter API #95

merged 1 commit into from
Jul 18, 2024

Conversation

vstinner
Copy link
Member

TODO: update API doc.

@vstinner
Copy link
Member Author

Wait until python/cpython#119184 is merged.

@vstinner vstinner mentioned this pull request May 22, 2024
Closed
@vstinner
WIP: Add PyUnicodeWriter API
f1cffbb 
TODO: update API doc.
@vstinner vstinner changed the title WIP: Add PyUnicodeWriter API Add PyUnicodeWriter API Jul 18, 2024
@vstinner vstinner marked this pull request as ready for review July 18, 2024 20:57
@vstinner vstinner merged commit 4094c64 into python:main Jul 18, 2024
21 checks passed
@vstinner vstinner deleted the writer branch July 18, 2024 20:59
@seberg
Copy link

seberg commented Aug 6, 2024

It seems to me that PyUnicodeWriter_WriteRepr and PyUnicodeWriter_WriteStr are missing the static inline to ensure multiple includes don't collide?

@vstinner
Copy link
Member Author

vstinner commented Aug 6, 2024

It seems to me that PyUnicodeWriter_WriteRepr and PyUnicodeWriter_WriteStr are missing the static inline to ensure multiple includes don't collide?

Oops, fixed by #104.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @seberg