-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script for handling translations #195
Conversation
0d01316
to
fb27bb0
Compare
fb27bb0
to
d271fac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Please could you add it somehow to the CI, so we know it at least runs without errors?
I was thinking if this script could be converted into Makefile
commands, but then we won't have Windows support, so that's no good. But we could add Makefile commands to call this script. This can be left for later though.
@hugovk workflow job added to tests.yml. My intention is to show the script works, but we can shape it better. |
It looks like this PR hasn't had a new activity in a while, is it finished now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, then I think we can merge this and iterate if needed, unless anyone else has any last comments?
In the Simplified Chinese documentation, there is an issue regarding hard-coded (edit: not hard-coded) strings such as "added in version". that cannot be translated. Can this PR solve this problem? |
No, that's a Sphinx string and it is not translated to zh_CN: https://github.com/sphinx-doc/sphinx/blob/116a430caca98580c8877cf7b0ba270eae9604bf/sphinx/locale/zh_CN/LC_MESSAGES/sphinx.po#L1951 Consider contributing in https://explore.transifex.com/sphinx-doc/sphinx-1/ |
Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Ezio Melotti <[email protected]>
Otherwise init command will be skipped
As one need to have POT before initializing PO
That's all from my side. Just a few minor changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
It looks great! I have a question: where should we translate this theme, and how will the translation automatically sync to this repository? |
@Wulian233 I mentioned that in the issue and it is yet to be defined. Some projects coordinate translation efforts in the own forge via pull/merge requests — not optimal for the translators. There is also translation platforms like Weblate, Transifex and others. My vote would be to use Weblate, which provides "libre hosting" for free software and features automatic opening and updating pull request for contributed translations. Tasks involve: setting up Weblate project (I can help with/do it), maintainers here update POT and give time before releasing to receive translations; and merging translation pull requests from Weblate. |
This is an initial take on the enable localization initiative adding a script to ease the babel call.
Usage:
See #194