-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generators benchmark #206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is fine, but it looks more like a microbenchmark. Have you compared 3.10 and 3.11 yet with this?
@ericsnowcurrently Do you think this makes a reasonable addition? I'm not sure where we stand on adding more microbenchmarks.
@kumaraditya303 The new files are missing trailing newlines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion.
pyperformance/data-files/benchmarks/bm_generators/run_benchmark.py
Outdated
Show resolved
Hide resolved
@kumaraditya303 We discussed adding microbenchmarks and the conclusion is that it's okay. So can you address the minor nits? Also, I am concerned about the greenlet-related failure in the 3.11-dev test. I am curious though -- how old is the 3.11-dev version on Ubuntu? Maybe it's an older alpha? |
3.11 is failing because of compilation error when compiling greenlet. See the tracking issue python/cpython#92898, it is fixed in main branch and 3.11 but no release has that fix yet. |
One thing microbenchmarks are very good at is finding regressions as it is focused on one thing only. |
Thanks for the benchmark, and thanks for the link to the issue with greenlet! |
@gvanrossum Benchmark results comparing 3.10 release and 3.12 main branch:
|
Nice! |
No description provided.