Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't consider comparing True and False as a dangerous comparison #9021

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Don't consider comparing True and False as a dangerous comparison #9021

merged 1 commit into from
Jun 18, 2020

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Jun 18, 2020

Fixes #9011.

@JukkaL JukkaL requested a review from ilevkivskyi June 18, 2020 15:15
@JukkaL JukkaL merged commit dc2c392 into master Jun 18, 2020
@JelleZijlstra JelleZijlstra deleted the bool-equality branch June 18, 2020 16:13
@JukkaL JukkaL mentioned this pull request Jun 19, 2020
Open
@ilevkivskyi ilevkivskyi mentioned this pull request Jun 19, 2020
Closed
ilevkivskyi pushed a commit that referenced this pull request Jun 22, 2020
@JukkaL
Don't consider comparing True and False as a dangerous comparison (#9021
e90d5f5 
)

Fixes #9011.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-overlapping identity check false-positive starting in 0.780
2 participants
@JukkaL @ilevkivskyi