Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add release tester #8963

Closed
wants to merge 1 commit into from
Closed

add release tester #8963

wants to merge 1 commit into from

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Jun 7, 2020

@msullivan
Copy link
Collaborator

Could you look into the CI failure?

@mr-c mr-c force-pushed the release_test branch 2 times, most recently from f44302f to 6af43e6 Compare June 12, 2020 16:37
@mr-c
Copy link
Contributor Author

mr-c commented Jun 12, 2020

@msullivan Fixing it now, thanks for the reminder!

@mr-c mr-c force-pushed the release_test branch 4 times, most recently from e0e9dac to 5202545 Compare June 13, 2020 08:13
@msullivan
Copy link
Collaborator

Still broken

@mr-c mr-c force-pushed the release_test branch 4 times, most recently from 48ebbb7 to 52d84f6 Compare June 18, 2020 11:57
@mr-c
Copy link
Contributor Author

mr-c commented Jun 18, 2020

@msullivan Commit 52d84f6 works, now rebasing one last time.

@mr-c mr-c force-pushed the release_test branch 2 times, most recently from a667de5 to 4d9a07d Compare June 18, 2020 14:09
@ilevkivskyi
Copy link
Member

We had a short offline discussion about this with @JukkaL: it looks like this is too slow to run in every CI build, to speed up 0.782 release, I include the MANIFEST changes as a separate PR #9033. In the meantime we can discuss what is the best way to run this test.

@mr-c
Copy link
Contributor Author

mr-c commented Jun 22, 2020

Thanks for looking at this. It is a beast of a gauntlet, but it did find many MANIFEST issues.

Happy to modify this further.A travis mode could skip all the test runs besides the last one.

@mr-c
Copy link
Contributor Author

mr-c commented Oct 13, 2020

Can we get a version of this merged? It would have detected #9587 before the release ..

@hauntsaninja
Copy link
Collaborator

A couple months ago we made a lot of MANIFEST improvements, including running check manifest in our release builds (mypyc/mypy_mypyc-wheels#14). The last couple releases seem to have gone well, ending a streak where we messed our sdists up pretty regularly. Given this, I'm going to close, but thank you for helping improve and test mypy releases! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants