-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add release tester #8963
add release tester #8963
Conversation
Could you look into the CI failure? |
f44302f
to
6af43e6
Compare
@msullivan Fixing it now, thanks for the reminder! |
e0e9dac
to
5202545
Compare
Still broken |
48ebbb7
to
52d84f6
Compare
@msullivan Commit 52d84f6 works, now rebasing one last time. |
a667de5
to
4d9a07d
Compare
Thanks for looking at this. It is a beast of a gauntlet, but it did find many MANIFEST issues. Happy to modify this further.A travis mode could skip all the test runs besides the last one. |
Can we get a version of this merged? It would have detected #9587 before the release .. |
A couple months ago we made a lot of MANIFEST improvements, including running check manifest in our release builds (mypyc/mypy_mypyc-wheels#14). The last couple releases seem to have gone well, ending a streak where we messed our sdists up pretty regularly. Given this, I'm going to close, but thank you for helping improve and test mypy releases! :-) |
As requested in #8949 (comment)
Adapted from https://github.com/common-workflow-language/cwltool/blob/814bd0405a7701efc7d63e8f0179df394c7766f7/release-test.sh which was based off of https://github.com/dib-lab/khmer/blob/6fde87ef565cece87306ea14971fac3c23954e77/doc/dev/release.rst
If there is a manual release process then I suggest adding
misc/release-test.sh
to it.