Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #5705 #8866

Merged
merged 1 commit into from
May 22, 2020
Merged

Fixes #5705 #8866

merged 1 commit into from
May 22, 2020

Conversation

ChetanKhanna
Copy link
Contributor

Added notes as suggested in the issue description after error from
incompatible arguments in subtype is raised.

@ChetanKhanna
Fixes python#5705
2f37e86 
Added notes as suggested in the issue description after error from
incompatible arguments in subtype is raised.
@Eric-Arellano
Copy link

As a MyPy user, this is awesome! Thank you for doing this!

JukkaL
JukkaL approved these changes May 22, 2020
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for improving the error message! This has been a common source of confusion for mypy users. Looks good.

@JukkaL JukkaL merged commit 05571b1 into python:master May 22, 2020
@ikonst ikonst mentioned this pull request May 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChetanKhanna @Eric-Arellano @JukkaL