Allow TypedDict key with literal type during construction #7645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored an operation away from `mypy.plugins.common` so that it is more cleanly reusable. Also kept an alias in the original location to avoid breaking existing plugins. Fixes #7644.
ilevkivskyi
approved these changes
Oct 7, 2019
test-data/unit/check-typeddict.test
Outdated
| num2: Literal['num'] | ||
| v = {num2: 2} | ||
| bad2: Literal['bad'] | ||
| v = {bad: 2} # E: Expected TypedDict key to be string literal |
There was a problem hiding this comment.
I suppose this should be bad2, otherwise bad2 would be unused in this test.
b0g3r
reviewed
Oct 7, 2019
| for lit in get_proper_types(possible_literals): | ||
| if isinstance(lit, LiteralType) and lit.fallback.type.fullname() == 'builtins.str': | ||
| val = lit.value | ||
| assert isinstance(val, str) |
There was a problem hiding this comment.
It's not a review comment, just my curiosity: why is this needed?
There was a problem hiding this comment.
Mypy thinks that the value could be an integer, for example, since it doesn't understand the fullname() check above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactored an operation away from
mypy.plugins.commonso that itis more cleanly reusable. Also kept an alias in the original location
to avoid breaking existing plugins.
Fixes #7644.