Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypyc build by removing conditional method definition in fastparse #6554

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

msullivan
Copy link
Collaborator

Remove the conditional method definition added in #6539, which mypyc
doesn't support.

Remove the conditional method definition added in #6539, which mypyc
doesn't support.
@msullivan msullivan requested a review from gvanrossum March 15, 2019 22:44
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for breaking this. TBH I don't recall why I made these conditional (especially since I din't make visit_Constant() conditional).

@msullivan
Copy link
Collaborator Author

Nobody needs to ever apologize for breaking things under mypyc until I set up CI for it >_>
(#6170)

@msullivan msullivan merged commit 83e5e4c into master Mar 15, 2019
@msullivan msullivan deleted the fix-mypyc branch March 15, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants