Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync typeshed (and fix typeshed build breakage) #6403

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Conversation

msullivan
Copy link
Collaborator

This requires another (wrong, of course) addition to the errors in
testNewAnalyzerBasicTypeshed_newsemanal, since there has been a typeshed
change that causes another newsemanal error.

(This is actually the main motivation for this sync, to allow fixing the
typeshed build breakage.)

This requires another (wrong, of course) addition to the errors in
testNewAnalyzerBasicTypeshed_newsemanal, since there has been a typeshed
change that causes another newsemanal error.

(This is actually the main motivation for this sync, to allow fixing the
typeshed build breakage.)
@msullivan
Copy link
Collaborator Author

I'm gonna just merge this but heads up @ilevkivskyi

Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's just do this!

@msullivan msullivan merged commit b8c78e6 into master Feb 14, 2019
@msullivan msullivan deleted the update-typeshed branch February 14, 2019 22:40
@JelleZijlstra
Copy link
Member

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants