Provide an "API" for invoking the daemon #5972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like the existing "api" for invoking mypy, it is just a thin wrapper around calling the main function.
ilevkivskyi
approved these changes
Nov 28, 2018
|
|
||
| def run_dmypy(args: List[str]) -> Tuple[str, str, int]: | ||
| from mypy.dmypy import main | ||
| return _run(lambda: main(args)) |
There was a problem hiding this comment.
IIUC this doesn't support incremental flushing of errors (maybe we will do this at some point), but it is the same for normal runs, so probably OK. Maybe add a comment about this.
| # We do this explicitly to avoid exceptions percolating up | ||
| # through mypy.api invocations | ||
| traceback.print_exc() | ||
| sys.exit(2) |
There was a problem hiding this comment.
I like this choice, I think there are still some situations where 1 can be returned on a traceback in the server, but I will fix those separately later.
gvanrossum
approved these changes
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the existing "api" for invoking mypy, it is just a thin wrapper
around calling the main function.