Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't always infer unions for conditional expressions #5095

Merged
merged 2 commits into from
May 24, 2018
Merged

Don't always infer unions for conditional expressions #5095

merged 2 commits into from
May 24, 2018

Commits on May 22, 2018

  1. Don't always infer unions for conditional expressions 

    Use a join for type of a conditional expression unless the type context
is a union type.

A recent change (#5041) modified the type to always use a union, but this
caused many problems in internal Dropbox repos that we aren't ready to
fix yet.
    @JukkaL
    JukkaL committed May 22, 2018
    Configuration menu
    Copy the full SHA
    adefaea View commit details
    Browse the repository at this point in the history

  2. Update comment

    @JukkaL
    JukkaL committed May 22, 2018
    Configuration menu
    Copy the full SHA
    0280a64 View commit details
    Browse the repository at this point in the history