Update credits to current state of affairs #3900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively, we should just list the core team and ex-core-team members and leave the rest up to GitHub history? |
JukkaL
reviewed
Aug 31, 2017
CREDITS
Outdated
| David Fisher <[email protected]> | ||
| Greg Price <[email protected]> | ||
| Jukka Lehtosalo <[email protected]> | ||
| Guido van Rossum <[email protected]> | ||
|
|
||
| Contributors (in alphabetical order, including typeshed): |
There was a problem hiding this comment.
At least mention that this is a partial list and suggest looking at the git history for a full set of contributors.
CREDITS
Outdated
| @@ -59,6 +57,7 @@ Contributors (in alphabetical order, including typeshed): | |||
| Daniel Shaulov | |||
| David Shea | |||
| Vita Smid | |||
| Ethan Smith | |||
|
The more I think about it the stronger I feel we should not have this list at all. (TBH I didn't even know it existed.) |
|
Ok, let's drop this and just mention current and previous core team members. We could also add a links to the release blog where we have more detailed per-release contributor information and to the github contributions page (https://github.com/python/mypy/graphs/contributors). |
- Delete attempt at listing all contributors (but keep "Additional thanks to" since I think that category is handpicked). - Link to commit history on GitHub and to release blog posts - List current and past core team in the same format as mypy-lang.org/about.html
|
How about this? |
|
These are now live on the website. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.