Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle symlinks correctly in Appveyor #3213

Merged
merged 3 commits into from
Apr 21, 2017
Merged

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Apr 21, 2017

Attempting fixes to python/typeshed#1175. Not intended to be merged.

@JelleZijlstra
Copy link
Member Author

It worked! Going to clean up the hacks and make this into a PR that can actually be merged.

@JelleZijlstra JelleZijlstra changed the title [Don't merge] Try to fix windows symlinks Handle symlinks correctly in Appveyor Apr 21, 2017
@gvanrossum
Copy link
Member

Thanks! Do those "git reset --hard" calls slow things down at all?

@JelleZijlstra
Copy link
Member Author

Thanks! Comparing https://ci.appveyor.com/project/gvanrossum/mypy/build/1.0.1233 and https://ci.appveyor.com/project/gvanrossum/mypy/build/1.0.1223, it doesn't look like it makes a big difference.

@gvanrossum gvanrossum merged commit 08f8fd9 into python:master Apr 21, 2017
@gvanrossum
Copy link
Member

OK, merged. I guess we can now restore some of the symlinks.

@JelleZijlstra JelleZijlstra deleted the symlinks branch April 21, 2017 23:11
@JelleZijlstra
Copy link
Member Author

Are there any other ones than the ntpath/macpath ones you removed recently? I can submit a typeshed PR to make them back into symlinks.

@gvanrossum
Copy link
Member

Those are probably the only ones -- none of the others apparently were ever exercised by various tests.

Here's a list of all current symlinks in the mypy and typeshed repos:

./test-data/.flake8@ -> ../typeshed/.flake8
./typeshed/stdlib/2/SocketServer.pyi@ -> ../3/socketserver.pyi
./typeshed/stdlib/2/builtins.pyi@ -> __builtin__.pyi
./typeshed/stdlib/2/macpath.pyi@ -> posixpath.pyi
./typeshed/stdlib/2/ntpath.pyi@ -> posixpath.pyi
./typeshed/stdlib/2/os2emxpath.pyi@ -> posixpath.pyi
./typeshed/third_party/3/enum.pyi@ -> ../../stdlib/3.4/enum.pyi

@gvanrossum
Copy link
Member

We may have to roll this back and try one of the other solutions; the Windows development experience is pretty bad currently (you have to be Administrator for many git commands). See e.g. #3222 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants