-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle symlinks correctly in Appveyor #3213
Conversation
It worked! Going to clean up the hacks and make this into a PR that can actually be merged. |
Thanks! Do those "git reset --hard" calls slow things down at all? |
Thanks! Comparing https://ci.appveyor.com/project/gvanrossum/mypy/build/1.0.1233 and https://ci.appveyor.com/project/gvanrossum/mypy/build/1.0.1223, it doesn't look like it makes a big difference. |
OK, merged. I guess we can now restore some of the symlinks. |
Are there any other ones than the ntpath/macpath ones you removed recently? I can submit a typeshed PR to make them back into symlinks. |
Those are probably the only ones -- none of the others apparently were ever exercised by various tests. Here's a list of all current symlinks in the mypy and typeshed repos:
|
This reverts commit 8b835f9. (Because we've fixed the issue in python/mypy#3213.)
We may have to roll this back and try one of the other solutions; the Windows development experience is pretty bad currently (you have to be Administrator for many git commands). See e.g. #3222 (comment) |
Attempting fixes to python/typeshed#1175. Not intended to be merged.