make stubgen not crash on sqlalchemy #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few modules in sqlalchemy don't react kindly to being imported, and some more don't like being reloaded. I don't see why stubgen needs to reload modules, so I removed the reload. I'm just ignoring modules that don't import.
JukkaL
reviewed
Mar 24, 2017
| search_path=search_path, | ||
| interpreter=interpreter) | ||
| except CantImport: | ||
| if not quiet: |
There was a problem hiding this comment.
We probably want to display error messages even in quiet mode.
There was a problem hiding this comment.
I made it print the error message either way. I noticed though that quiet mode is unused; it defaults to False and nothing outside of tests calls generate_stub_for_module with quiet=True.
|
Thanks! LGTM. Not sure why I did the module reload -- maybe it was for interactive use or for tests. We'll see if removing it causes some trouble. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few modules in sqlalchemy don't react kindly to being imported, and some
more don't like being reloaded. I don't see why stubgen needs to reload
modules, so I removed the reload. I'm just ignoring modules that don't
import.
This helps address python/typeshed#974.