Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reverted] Fixes to union simplification, isinstance and more #3025

Merged
merged 19 commits into from
Mar 29, 2017
Merged

[Reverted] Fixes to union simplification, isinstance and more #3025

merged 19 commits into from
Mar 29, 2017

Commits on Mar 20, 2017

  1. Fixes to union simplification and isinstance 

    The main change is that unions containing Any are no longer simplified
to just Any.

This required changes in various other places to keep the existing
semantics, and resulted in some fixes to existing test cases.
    @JukkaL
    JukkaL committed Mar 20, 2017
    Configuration menu
    Copy the full SHA
    c53e0ca View commit details
    Browse the repository at this point in the history

  2. Fix #2978.

    @JukkaL
    JukkaL committed Mar 20, 2017
    Configuration menu
    Copy the full SHA
    dc62a99 View commit details
    Browse the repository at this point in the history

  3. Add test case 

    Fix #1914.
    @JukkaL
    JukkaL committed Mar 20, 2017
    Configuration menu
    Copy the full SHA
    07d64f5 View commit details
    Browse the repository at this point in the history

  4. Fix test failures

    @JukkaL
    JukkaL committed Mar 20, 2017
    Configuration menu
    Copy the full SHA
    0beffee View commit details
    Browse the repository at this point in the history

  5. Fix meet of a broken named tuple and a good named tuple

    @JukkaL
    JukkaL committed Mar 20, 2017
    Configuration menu
    Copy the full SHA
    e3ff2c7 View commit details
    Browse the repository at this point in the history

  6. Fix erasing union types

    @JukkaL
    JukkaL committed Mar 20, 2017
    Configuration menu
    Copy the full SHA
    4cb8673 View commit details
    Browse the repository at this point in the history

  7. Remove references to Void

    @JukkaL
    JukkaL committed Mar 20, 2017
    Configuration menu
    Copy the full SHA
    fc57a76 View commit details
    Browse the repository at this point in the history

  8. Proper subtype checks use type promotions

    @JukkaL
    JukkaL committed Mar 20, 2017
    Configuration menu
    Copy the full SHA
    9cf9114 View commit details
    Browse the repository at this point in the history

  9. Don't call union simplification during semantic analysis 

    We generally don't have fully constructed TypeInfos so
we can't do proper union simplification. Just implement
simple-minded simplifaction that deals with the cases we
care about.
    @JukkaL
    JukkaL committed Mar 20, 2017
    Configuration menu
    Copy the full SHA
    d406157 View commit details
    Browse the repository at this point in the history

  10. Add union simplification test cases

    @JukkaL
    JukkaL committed Mar 20, 2017
    Configuration menu
    Copy the full SHA
    d745a50 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2017

  1. Address review feedback

    @JukkaL
    JukkaL committed Mar 24, 2017
    Configuration menu
    Copy the full SHA
    a638e72 View commit details
    Browse the repository at this point in the history

  2. Fix test case failures

    @JukkaL
    JukkaL committed Mar 24, 2017
    Configuration menu
    Copy the full SHA
    ca511d8 View commit details
    Browse the repository at this point in the history

  3. Flatten Optional[Union[...]] types

    @JukkaL
    JukkaL committed Mar 24, 2017
    Configuration menu
    Copy the full SHA
    807924c View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2017

  1. Add TODO comment about make_simplified_union

    @JukkaL
    JukkaL committed Mar 27, 2017
    Configuration menu
    Copy the full SHA
    ef46cfa View commit details
    Browse the repository at this point in the history

  2. Add test case

    @JukkaL
    JukkaL committed Mar 27, 2017
    Configuration menu
    Copy the full SHA
    6cd09f1 View commit details
    Browse the repository at this point in the history

  3. Partially address comments about type object types

    @JukkaL
    JukkaL committed Mar 27, 2017
    Configuration menu
    Copy the full SHA
    39f94a1 View commit details
    Browse the repository at this point in the history

  4. Fixes to TypedDict proper subtype checks + add tests

    @JukkaL
    JukkaL committed Mar 27, 2017
    Configuration menu
    Copy the full SHA
    0826cc3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into proper-subtype

    @JukkaL
    JukkaL committed Mar 27, 2017
    Configuration menu
    Copy the full SHA
    baafcd1 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2017

  1. Merge branch 'master' into proper-subtype

    @JukkaL
    JukkaL committed Mar 29, 2017
    Configuration menu
    Copy the full SHA
    a06b41c View commit details
    Browse the repository at this point in the history