Remove weird implementation of --show_traceback and --pdb. #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also set options.show_traceback in all test modules I could find. These flags used to be implemented as globals in errors.py that had to be set by calling set_show_tb() or set_drop_into_pdb() (and setting the corresponding Options attributes had no effect). Now they're just regular options. I had to adjust some plumbing to give report_internal_error() access to the options but it was easier than I thought.
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also set options.show_traceback in all test modules I could find.
These flags used to be implemented as globals in errors.py that had to
be set by calling set_show_tb() or set_drop_into_pdb() (and setting
the corresponding Options attributes had no effect). Now they're just
regular options. I had to adjust some plumbing to give
report_internal_error() access to the options but it was easier than I
thought.