Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RawExpressionType.accept crash with --cache-fine-grained #17588

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Jul 26, 2024

Commit 1072c78 (#17148) converted all quoted types into RawExpressionType, which raised an AssertionError when accepting a TypeTriggersVisitor.

Commit 1072c78 (python#17148) converted all
quoted types into RawExpressionType, which raised an AssertionError
when accepting a TypeTriggersVisitor.

Fixes python#17587.

Signed-off-by: Anders Kaseorg <[email protected]>
@JelleZijlstra
Copy link
Member

This looks like it could work, but one of the mypy-primer runs timed out after 6 hours. Re-running it to see if it's a fluke or this PR is introducing/exposing a bug that makes mypy hang on some code.

@andersk
Copy link
Contributor Author

andersk commented Jul 26, 2024

Hmm. It looks like it’s stuck in the same way (attempt 1, attempt 2).

@andersk
Copy link
Contributor Author

andersk commented Jul 26, 2024

@JelleZijlstra
Copy link
Member

Thanks, let's see if that helps.

Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@JelleZijlstra JelleZijlstra merged commit 8b74b5a into python:master Jul 26, 2024
36 of 37 checks passed
@andersk andersk deleted the RawExpressionType.accept branch July 26, 2024 23:30
hauntsaninja pushed a commit that referenced this pull request Jul 27, 2024
)

Commit 1072c78 (#17148) converted all
quoted types into `RawExpressionType`, which raised an `AssertionError`
when `accept`ing a `TypeTriggersVisitor`.

- Fixes #17574.
- Fixes #17587.

Signed-off-by: Anders Kaseorg <[email protected]>
mr-c pushed a commit to mr-c/mypy that referenced this pull request Aug 14, 2024
md384 pushed a commit to md384/mypy that referenced this pull request Aug 14, 2024
hauntsaninja pushed a commit that referenced this pull request Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants