-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ParamSpec mapping with functools.partial #17355
Merged
ilevkivskyi
merged 21 commits into
python:master
from
sterliakov:bugfix/st-paramspec-with-functools-partial
Oct 26, 2024
Merged
Changes from 16 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5cdb753
Reject ParamSpec-typed callables calls with insufficient arguments
sterliakov 3b2297f
Reuse params preprocessing logic for generic functions
sterliakov a32ad3f
Only perform deep expansion on overloads when ParamSpec is present
sterliakov 63995e3
Tidy up code a bit
sterliakov be2c49b
Merge remote-tracking branch 'upstream/master' into bugfix/st-paramsp…
sterliakov 0a658a7
Always pick ParamSpec-containing overloads as plausible candidates
sterliakov 63f9438
Remove parameters thaat are no longer used
sterliakov 786fb55
Merge branch 'master' into bugfix/st-paramspec-missing-args
sterliakov 1903402
Undo style change to make it easier to review, feel free to add in se…
hauntsaninja 512a722
Support ParamSpec + functools.partial
sterliakov 558a35f
Merge remote-tracking branch 'upstream/master' into bugfix/st-paramsp…
sterliakov 01390c0
Fix lost error in test
sterliakov b23efe8
Merge remote-tracking branch 'upstream/master' into bugfix/st-paramsp…
sterliakov bf60ec1
Remove param_spec_args_bound - new version produces worse error messa…
sterliakov a660f1f
Add test scenario
sterliakov 5d46d85
Fix typing, use `immutable` for storing binding information
sterliakov bbaf9de
Merge remote-tracking branch 'upstream/master' into bugfix/st-paramsp…
sterliakov 4d55122
Fix duplicated testcase
sterliakov b077063
Merge remote-tracking branch 'upstream/master' into bugfix/st-paramsp…
sterliakov aa1391c
Replace naive check by arg kinds with more robust type-aware check
sterliakov 31a7492
Deduplicate isinstance() checks
sterliakov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bodies of
run_bad2
andrun_bad3
look identical. Did you want to test something else here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ough, thanks for spotting! Updated.