Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mypy daemon documentation note about local partial types #16782

Merged
merged 3 commits into from
Jan 14, 2024

Conversation

MakonnenMak
Copy link
Contributor

The existing documentation almost makes it seem like the user has the option to toggle this.

Updated wording to say strictly denoting it's not configurable with explanation from the code here

mypy/mypy/dmypy_server.py

Lines 196 to 198 in fbb738a

# Fine-grained incremental doesn't support general partial types
# (details in https://github.com/python/mypy/issues/4492)
options.local_partial_types = True
.

(Explain how this PR changes mypy.)

MakonnenMak and others added 2 commits January 13, 2024 21:05
The existing documentation almost makes it seem like the user has the option to toggle this. 

Updated wording to say strictly denoting it's not configurable with explanation from the code here https://github.com/python/mypy/blob/fbb738a4626976f83a7412df73533d87483a31b7/mypy/dmypy_server.py#L198.
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hauntsaninja hauntsaninja merged commit 186ace3 into python:master Jan 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants