Build the docs in CI for all PRs touching the mypy/ directory
#16068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- python#16061 added a new error code, but didn't add any docs for the new error code - Because nothing in the `docs/` directory was modified, the docs CI job didn't run on that PR - Now the docs build is failing on `master` because we have an error code without any documentation: https://github.com/python/mypy/actions/runs/6112378542/job/16589719563
AlexWaygood
commented
Sep 7, 2023
ikonst
approved these changes
Sep 7, 2023
This comment has been minimized.
This comment has been minimized.
hauntsaninja
approved these changes
Sep 7, 2023
That maybe opens up a small risk of e.g. what if we refactored things in the future and put the error codes somewhere else... but yeah, that seems unlikely! I'll make the change |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Sep 9, 2023
A new error code was introduced in python#16061 As per python#16068, we didn't previously run doc builds on changes to errorcodes.py, causing tests to fail on master when this was merged. Renaming the code as per: python#16061 (comment) All type ignores should be unsafe, so we should save the unsafe adjective for things that are really unsafe. As it stands, there are many cases where overloads overlap somewhat benignly.
hauntsaninja
added a commit
that referenced
this pull request
Sep 10, 2023
A new error code was introduced in #16061 As per #16068, we didn't previously run doc builds on changes to errorcodes.py, causing tests to fail on master when this was merged. Renaming the code as per: #16061 (comment) All type ignores should be unsafe, so we should save the unsafe adjective for things that are really unsafe. As it stands, there are many cases where overloads overlap somewhat benignly. Fixes #8656
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/directory was modified, the docs CI job didn't run on that PRmasterbecause we have an error code without any documentation: https://github.com/python/mypy/actions/runs/6112378542/job/16589719563