Teach stubgen to work with complex and unary expressions
#15661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR title says stubtest -- you mean stubgen, right? |
sobolevn
changed the title
stubtest to work with complex and unary expressionsstubgen to work with complex and unary expressions
|
|
JelleZijlstra
approved these changes
Jul 13, 2023
AlexWaygood
reviewed
Jul 13, 2023
mypy/stubgen.py
Outdated
| @@ -1396,6 +1397,8 @@ def is_private_member(self, fullname: str) -> bool: | |||
| def get_str_type_of_node( | |||
| self, rvalue: Expression, can_infer_optional: bool = False, can_be_any: bool = True | |||
| ) -> str: | |||
| rvalue = self.unwrap_unary_expr(rvalue) | |||
There was a problem hiding this comment.
I'm not sure we should be doing this with all possible rvalues. Some unary expressions change the type:
>>> type(-True)
<class 'int'>There was a problem hiding this comment.
I guess it's pretty unlikely that this would ever come up in real code, but it would still be nice to be correct here imo :)
There was a problem hiding this comment.
Hm, ~True is also a well-known anti-pattern. I agree, I will include only some cases. Like not bool and +|- int|float|complex
|
Now I only allow a very small subset of unary expressions. But, ones I allow make a lot of sense and are very common. |
AlexWaygood
reviewed
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.