Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process NamedTuple decorators in semantic analyzer #15513

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Process NamedTuple decorators in semantic analyzer #15513

merged 2 commits into from
Jun 28, 2023

Conversation

ichard26
Copy link
Collaborator

@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

graphql-core (https://github.com/graphql-python/graphql-core): typechecking got 1.07x slower (389.1s -> 414.7s)
(Performance measurements are based on a single noisy sample)

@hauntsaninja hauntsaninja merged commit 9a4a5aa into python:master Jun 28, 2023
@ichard26 ichard26 deleted the process-namedtuple-decos branch June 28, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mypyc internal error: should be unreachable on final NamedTuple
3 participants
@ichard26 @ilevkivskyi @hauntsaninja