(📚) Update comment in Literal example to explain why the redundant overload is needed
#14765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t overload is needed
|
@JelleZijlstra Do you think this is a good one? This example has caused confusion about the nature of |
|
I'm not convinced this PR is correct but I don't have time or interest in discussing this in detail, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example is problematic, the wording indicates that there is some difference between
Literal[True, False]andbool, and that all other values ("normal bools" instead of "literal bools"), need to be captured in their own case.overloads that exhaust finiteLiterals(bool/Enum) not treated as exhaustive #14764