Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function argument inference for constrained type variables within unions (Fixes #3644). #14396

Merged

Conversation

tyralla
Copy link
Collaborator

@tyralla tyralla commented Jan 5, 2023

Fix function argument inference for constrained type variables within unions (Fixes #3644).

Handling of constrained type variables of function filter_satisfiable of module constraints was missing (as was indicated by a removed ToDo).

… unions (Fixes 3644).

Handling of constrained type variables of function `filter_satisfiable` of module `constraints` was missing (as was indicated by a removed ToDo).
@github-actions

This comment has been minimized.

@tyralla tyralla changed the title Fix function argument inference for constrained type variables within unions (Fixes 3644). Fix function argument inference for constrained type variables within unions (Fixes #3644). Jan 5, 2023
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hauntsaninja hauntsaninja merged commit 98cc165 into python:master Jan 6, 2023
@tyralla
Copy link
Collaborator Author

tyralla commented Jan 6, 2023

Using any looks cleaner. Thank's for the beautification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeVar in generic union member gets restricted to first constraint
2 participants