Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(🎁) Add 3.12-dev to CI #14050

Merged
merged 3 commits into from
Dec 14, 2022
Merged

(🎁) Add 3.12-dev to CI #14050

merged 3 commits into from
Dec 14, 2022

Conversation

KotlinIsland
Copy link
Contributor

@KotlinIsland KotlinIsland commented Nov 9, 2022 •
edited
Loading

Adding a fail-able 3.12-dev job to the CI

@KotlinIsland KotlinIsland changed the title Add 3.12-dev to CI (🎁) Add 3.12-dev to CI Nov 9, 2022
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@KotlinIsland
Copy link
Contributor Author

Very strange, pytest seems to timeout github right near the end, I'll continue investigating when I have time.

@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra
Copy link
Member

Maybe make it skip the lxml install; it's probably not worth it to try to build from source, and we can still get useful data from tests that don't rely on XML reports.

@hauntsaninja
Copy link
Collaborator

Yup, do the opposite of #14134

@KotlinIsland KotlinIsland force-pushed the 3.12 branch 2 times, most recently from d28e37c to c7666be Compare December 8, 2022 21:42
@github-actions

This comment has been minimized.

Sign in to view
@hauntsaninja
Copy link
Collaborator

Hmm, 40 minutes and counting. Doesn't bode well

@KotlinIsland
Copy link
Contributor Author

Yeah, there is some issue with the tests right at the end, I'm temporarily increasing pytest verbosity and rerunning.

@github-actions

This comment has been minimized.

Sign in to view
@KotlinIsland
Copy link
Contributor Author

@JelleZijlstra @hauntsaninja If you see this before it times out (6 hours), could you cancel the current run so I can analyze the logs?

@JelleZijlstra
Copy link
Member

done

@KotlinIsland
Copy link
Contributor Author

It's mypyc/test/test_run.py::TestRun::run-functions.test::testDecorators1 that it's hanging on.

@KotlinIsland KotlinIsland force-pushed the 3.12 branch 2 times, most recently from 1e44f40 to 9d990e4 Compare December 9, 2022 03:37
@github-actions

This comment has been minimized.

Sign in to view
@KotlinIsland KotlinIsland force-pushed the 3.12 branch 9 times, most recently from a9e77c3 to 01f2357 Compare December 10, 2022 07:52
@KotlinIsland KotlinIsland force-pushed the 3.12 branch 13 times, most recently from e758e08 to e04816a Compare December 10, 2022 09:14
@github-actions

This comment has been minimized.

Sign in to view
@KotlinIsland
Copy link
Contributor Author

@JelleZijlstra Wanna review this now?

hauntsaninja
hauntsaninja approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this seems fine to me. Let me know if you're interested in fixing any of the failing tests and need help

@KotlinIsland
Copy link
Contributor Author

Okay, this seems fine to me. Let me know if you're interested in fixing any of the failing tests and need help

If I have time I can look into it, is this good to merge now?

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hauntsaninja hauntsaninja merged commit d62be28 into python:master Dec 14, 2022
@KotlinIsland KotlinIsland deleted the 3.12 branch December 15, 2022 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
topic-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KotlinIsland @JelleZijlstra @hauntsaninja @AlexWaygood