Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make invalid type ignore comments non-blocking #13506

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Make invalid type ignore comments non-blocking #13506

merged 2 commits into from
Aug 25, 2022

Commits on Aug 25, 2022

  1. Make invalid type ignore comments non-blocking 

    Blocking errors are a bad user experience and there's no reason for this
one to be one / there is another code path for invalid type ignores that
is non-blocking.

Fixes half of python#12299. The half it doesn't fix is that ideally users
shouldn't be getting these warnings from third party libraries.
Also see python#12162 (comment)
But that's for another PR
    @hauntsaninja
    hauntsaninja committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    c82781c View commit details
    Browse the repository at this point in the history

  2. fix tests

    @hauntsaninja
    hauntsaninja committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    c1d6958 View commit details
    Browse the repository at this point in the history