Fix forward references and generic inheritance in attrs classes #12772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to #12762, but for attrs classes.
This comment has been minimized.
This comment has been minimized.
|
The new errors from home-assistant look a bit suspicious. Maybe unsupported converters now generate too many errors. |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
ilevkivskyi
approved these changes
May 13, 2022
| return True | ||
|
|
||
| for super_info in ctx.cls.info.mro[1:-1]: | ||
| if 'attrs_tag' in super_info.metadata and 'attrs' not in super_info.metadata: |
There was a problem hiding this comment.
Maybe at some point we should switch to using constants (e.g. to avoid typos).
This was referenced May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the attrs plugin to a later pass, so that we won't have placeholders. Fix
various issues related to forward references and generic inheritance, including
some crashes.
This is follow-up to #12762 and related to #12656 and #12633.