pyinfo: Use sys.path instead of the site.getsitepackages procedure. #12530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes python#5701. * mypy/pyinfo.py (getsitepackages): Use sys.path to discover packages. * mypy/modulefinder.py (get_site_packages_dirs): Adjust accordingly. (expand_site_packages, _parse_pth_file, _make_abspath): Remove procedures. (compute_search_paths): Adjust accordingly. * mypy/main.py (process_options): Likewise.
Apteryks
changed the title
|
Diff from mypy_primer, showing the effect of this PR on open source code: aiohttp (https://github.com/aio-libs/aiohttp)
+ /tmp/mypy_primer/projects/aiohttp is in the PYTHONPATH. Please change directory so it is not.
|
|
Thanks, closing as a duplicate of #11143 which handles more cases, passes tests, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5701.
(expand_site_packages, _parse_pth_file, _make_abspath): Remove procedures.
(compute_search_paths): Adjust accordingly.
I've applied this patch to the
python-mypyin GNU Guix; which continued passing its test suite. This in turned enabled the python-pytest-enabler test suite to pass for the first time; previously it would fail due to mypy being unable to locate the stubs files, even they were installed.I believe this is because mypy would only look (by default) at the Python installation site-packages directory, which in non-file hierarchy standard distributions is bound to fail.
Using
sys.pathinstead ofsite.getsitepackagesis more robust generally (it benefits from Python's site.py treatment) and avoids reinventing the wheel in mypy (such as parsing .pth files).