Use tomllib on Python 3.11 #12305
Merged
Use tomllib on Python 3.11 #12305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
| @@ -449,10 +454,8 @@ def _is_compatible_stub_package(self, stub_dir: str) -> bool: | |||
| """ | |||
| metadata_fnam = os.path.join(stub_dir, 'METADATA.toml') | |||
| if os.path.isfile(metadata_fnam): | |||
| # Delay import for a possible minor performance win. | |||
There was a problem hiding this comment.
Fine to remove it since configparser.py already unconditionally imports tomllib anyway.
JelleZijlstra
approved these changes
Mar 8, 2022
cdce8p
pushed a commit
to cdce8p/mypy
that referenced
this pull request
Mar 10, 2022
This was referenced May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.