Remove test samples #11906
Merged
Remove test samples #11906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know that these have caught any real issues in the last couple years, however, the standard library ones have been a bit of a pain, most recently in python#11905. Jukka was okay removing the stdlib samples two years ago, see python#8838 (comment) We now have tooling like mypy primer that runs mypy over a much larger and more varied corpus of code on every PR. The other samples haven't caused me much bother, but except for crawl2, they're all very simple. I don't think they provide us much value, unless they have sentimental or historical value.
Merged
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
I don't know that these have caught any real issues in the last couple years, however, the standard library ones have been a bit of a pain, most recently in python#11905. Jukka was okay removing the stdlib samples two years ago, see python#8838 (comment) We now have tooling like mypy primer that runs mypy over a much larger and more varied corpus of code on every PR. The other samples haven't caused me much bother (except for crawl, which I removed in python#9375), but except for crawl2, they're all very simple. I don't think they provide us much value, unless they have sentimental or historical value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know that these have caught any real issues in the last couple
years, however, the standard library ones have been a bit of a pain,
most recently in #11905.
Jukka was okay removing the stdlib samples two years ago, see
#8838 (comment)
We now have tooling like mypy primer that runs mypy over a much larger
and more varied corpus of code on every PR.
The other samples haven't caused me much bother (except for crawl,
which I removed in #9375), but except for crawl2, they're all very simple.
I don't think they provide us much value, unless they have sentimental or
historical value.