Preserves interpreting multi-line strings as a single value for exclude in TOML files
#11828
Conversation
|
Doc screenshots:
… links to the section that contains …
Created with: |
posita
force-pushed
the
posita/0/multiple-excludes-in-toml-fix-11825
branch
2 times, most recently
from
0fd2c8e to
f483ee1
Compare
posita
changed the title
exclude as a multi-line basic string in TOML files
mypy/config_parser.py
Outdated
| @@ -143,6 +149,7 @@ def check_follow_imports(choice: str) -> str: | |||
| 'disable_error_code': try_split, | |||
| 'enable_error_code': try_split, | |||
| 'package_root': try_split, | |||
| 'exclude': str_or_seq_of_strs_as_list_of_strs, | |||
There was a problem hiding this comment.
This function name is a bit verbose. I'm open to suggestions.
There was a problem hiding this comment.
Agreed and don't have a supremely better idea. Maybe into_list - implying that list is the result, but not implying that splitting is happening.
posita
changed the title
exclude as a multi-line basic string in TOML filesexclude in TOML files
|
This looks great! |
posita
force-pushed
the
posita/0/multiple-excludes-in-toml-fix-11825
branch
from
f483ee1 to
66c0b7d
Compare
docs/source/config_file.rst
Outdated
| [tool.mypy] | ||
| exclude = [ | ||
| '^file1\.py$', # literal (no escaping) | ||
| "^file2\\.py$", # basic (backslash needs escaping) |
There was a problem hiding this comment.
| "^file2\\.py$", # basic (backslash needs escaping) | |
| "^windows_dir\\file2\.py$", # a literal backslash should be escaped with a backslash |
There was a problem hiding this comment.
See my comment above.
Multiple regexes are expressed as a sequence. Fixes python#11825.
posita
force-pushed
the
posita/0/multiple-excludes-in-toml-fix-11825
branch
from
66c0b7d to
bbd5431
Compare
There was a problem hiding this comment.
This looks good to me.
Thank you @posita and @mawillcockson for fixing this!
I brought this up in #11700, so hopefully we get a 0.931 that adds this (and whatever we decide for #11830)
Co-authored-by: Matthew W <[email protected]>
Fixes python#11830. Depends on python#11828.
@hauntsaninja, see #11881 and this comment (in case you wanted to update this). |
|
Thank you for fixing this! |
…ude` in TOML files (#11828) Multiple regexes are expressed as a sequence. Fixes #11825. Co-authored-by: Matthew W <[email protected]> Co-authored-by: Shantanu <[email protected]>
…ude` in TOML files (python#11828) Multiple regexes are expressed as a sequence. Fixes python#11825. Co-authored-by: Matthew W <[email protected]> Co-authored-by: Shantanu <[email protected]>
ghost
mentioned this pull request
Introduces an alternative where multiple regexes can be expressed as an array. Includes additional unit tests.
This preserves backward compatibility by allowing multi-line values in TOML to be treated as a single regex for those who have come to rely on that while exposing an array-based expression as a more ergonomic (and TOML-like) alternative.
Fixes #11825. Obsoletes (or is obsoleted by) #11746.