Recognize Hashable
as a real protocol, refs #11799
#11802
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for spamming with PR, but this problem caught my eye 🙂
When this piece of code was checked:
Mypy revealed that
Hashable
is() -> object
. It happened, becauseis_subtype(explicit_type, default_ret_type, ignore_type_params=True)
wasTrue
, whereexplicit_type=object
anddefault_ret_type=Hashable
. It happened becauseobject
has__hash__
method.The only thing that poped out of my head is to simply exclude protocols from this condition.
I guess that we might double check protocols with
__new__
and__init__
to be sure. But, I am not able to think of proper test cases for this. Any ideas? Or is my single test good enough?I am adding
pythoneval
test, because of the complexity in howHashable
is defined and analyzed in real life.Closes #11799