stubtest: increase coverage #11634
Merged
stubtest: increase coverage #11634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2021 17:42
|
(fixing lint on master in #11635) |
JelleZijlstra
approved these changes
Nov 29, 2021
This was referenced Dec 22, 2021
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
Co-authored-by: hauntsaninja <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With missing stubs and no runtime
__all__, we now correctly find module level constants of primitive types (like int or str). While this can have some false positives, e.g. withfrom module import int_constant, I think this is an important fix to make since it allows for saner user expectations (see the change totest_missing_no_runtime_all).The change from checking
module_publictonot module_hiddenallows better checking in cases where the stub may wish to type runtime details. This corresponds to checking_fandgintest_non_public_1andtest_non_public_2. The new errors in typeshed seem largely worthwhile.