Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now we can override attributes with methods, refs #10134 #11561

Merged
merged 5 commits into from
Nov 18, 2021
Merged

Now we can override attributes with methods, refs #10134 #11561

merged 5 commits into from
Nov 18, 2021

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Nov 16, 2021

It was crashing before this patch.

Closes #10134
Closes #11556
Refs #5425

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos :)

test-data/unit/check-classes.test Outdated Show resolved Hide resolved
test-data/unit/check-classes.test Outdated Show resolved Hide resolved
test-data/unit/check-classes.test Outdated Show resolved Hide resolved
@sobolevn
Copy link
Member Author

@AlexWaygood thanks!

Copy link
Collaborator

@97littleleaf11 97littleleaf11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@97littleleaf11 97littleleaf11 merged commit cc6c8a9 into python:master Nov 18, 2021
tushar-deepsource pushed a commit to DeepSourceCorp/mypy that referenced this pull request Jan 20, 2022
…n#11561)

Now we can override attributes with methods.

Closes python#10134
Closes python#11556

Co-authored-by: Alex Waygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complex inheritance generates INTERNAL ERROR INTERNAL ERROR with __hash__ = None
3 participants