pyopenssl types package corrected #10656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's now also available for Python 3
JelleZijlstra
approved these changes
Jun 16, 2021
|
Diff from mypy_primer, showing the effect of this PR on open source code: scrapy (https://github.com/scrapy/scrapy.git)
+ scrapy/utils/ssl.py:1: error: Library stubs not installed for "OpenSSL" (or incompatible with Python 3.8)
+ scrapy/utils/ssl.py:2: error: Library stubs not installed for "OpenSSL._util" (or incompatible with Python 3.8)
+ scrapy/core/downloader/tls.py:3: error: Library stubs not installed for "OpenSSL" (or incompatible with Python 3.8)
+ scrapy/core/downloader/contextfactory.py:3: error: Library stubs not installed for "OpenSSL" (or incompatible with Python 3.8)
+ scrapy/core/downloader/contextfactory.py:3: note: Hint: "python3 -m pip install types-pyOpenSSL"
+ scrapy/core/downloader/contextfactory.py:3: note: (or run "mypy --install-types" to install all missing stub packages)
+ scrapy/core/downloader/contextfactory.py:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
- scrapy/cmdline.py:6: note: (or run "mypy --install-types" to install all missing stub packages)
- scrapy/cmdline.py:6: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
+ tests/mockserver.py:12: error: Library stubs not installed for "OpenSSL" (or incompatible with Python 3.8)
+ tests/test_webclient.py:11: error: Library stubs not installed for "OpenSSL.SSL" (or incompatible with Python 3.8)
+ tests/test_webclient.py:11: error: Library stubs not installed for "OpenSSL" (or incompatible with Python 3.8)
|
JukkaL
pushed a commit
that referenced
this pull request
Jun 21, 2021
It's now also available for Python 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyopenssl's types package name was corrected in typeshed. It's now also available for Python 3.