Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail if an old typed_ast version is installed #2384

Closed
JukkaL opened this issue Oct 31, 2016 · 2 comments
Closed

Fail if an old typed_ast version is installed #2384

JukkaL opened this issue Oct 31, 2016 · 2 comments

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Oct 31, 2016

Users have had some hard-to-diagnose problems due to having a stale version of typed_ast. What if we failed hard if the installed typed_ast is older than what the release was tested with? We may need to include additional version information in typed_ast (such as __version__).

@gvanrossum
Copy link
Member

I am hoping that #2340 will address this differently (by specifying
versioned dependencies) but I am stuck figuring out how to make
dependencies platform-specific. (See discussion there.)

On Mon, Oct 31, 2016 at 2:11 AM, Jukka Lehtosalo [email protected]
wrote:

Users have had some hard-to-diagnose problems due to having a stale
version of typed_ast. What if we failed hard if the installed typed_ast
is older than what the release was tested with? We may need to include
additional version information in typed_ast (such as version).


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#2384, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACwrMj0aWRt_5zRFMcdEMqWtmynMhxrOks5q5bDAgaJpZM4KkzhW
.

--Guido van Rossum (python.org/~guido)

@JukkaL
Copy link
Collaborator Author

JukkaL commented Jan 16, 2017

I believe that #2452 fixed this.

@JukkaL JukkaL closed this as completed Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants