Skip to content

Commit

Permalink
teststubtest: drop StubtestIntegration (#9635)
Browse files Browse the repository at this point in the history
I did some work to speed up stubtest tests substantially in #9621
This is a lesser win. The argument to get rid of it is that it's the
slowest mypy test and just testing for crashes on typeshed doesn't
provide much value. Since this was written we started running stubtest
in typeshed CI and in practice all changes are tested on typeshed
anyway.

Co-authored-by: hauntsaninja <>
  • Loading branch information
hauntsaninja authored Oct 25, 2020
1 parent af99ebc commit f220ce5
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
6 changes: 0 additions & 6 deletions mypy/test/teststubtest.py
Original file line number Diff line number Diff line change
Expand Up @@ -848,9 +848,3 @@ def test_config_file(self) -> None:
)
output = run_stubtest(stub=stub, runtime=runtime, options=[], config_file=config_file)
assert output == ""


class StubtestIntegration(unittest.TestCase):
def test_typeshed(self) -> None:
# check we don't crash while checking typeshed
test_stubs(parse_options(["--check-typeshed"]))
6 changes: 0 additions & 6 deletions runtests.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
MYPYC_EXTERNAL = 'TestExternal'
MYPYC_COMMAND_LINE = 'TestCommandLine'
ERROR_STREAM = 'ErrorStreamSuite'
STUBTEST_INTEGRATION = 'StubtestIntegration'


ALL_NON_FAST = [
Expand All @@ -45,16 +44,12 @@
MYPYC_EXTERNAL,
MYPYC_COMMAND_LINE,
ERROR_STREAM,
STUBTEST_INTEGRATION,
]


# These must be enabled by explicitly including 'mypyc-extra' on the command line.
MYPYC_OPT_IN = [MYPYC_RUN, MYPYC_RUN_MULTI]

# These must be enabled by explicitly including 'stubtest' on the command line.
STUBTEST_OPT_IN = [STUBTEST_INTEGRATION]

# We split the pytest run into three parts to improve test
# parallelization. Each run should have tests that each take a roughly similar
# time to run.
Expand Down Expand Up @@ -82,7 +77,6 @@
# Mypyc tests that aren't run by default, since they are slow and rarely
# fail for commits that don't touch mypyc
'mypyc-extra': 'pytest -k "%s"' % ' or '.join(MYPYC_OPT_IN),
'stubtest': 'pytest -k "%s"' % ' or '.join(STUBTEST_OPT_IN),
}

# Stop run immediately if these commands fail
Expand Down

0 comments on commit f220ce5

Please sign in to comment.