workaround regression for now

python · Oct 25, 2024 · 778dbec · 778dbec
1 parent ac79825
commit 778dbec
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/mypy/modulefinder.py b/mypy/modulefinder.py
@@ -554,10 +554,9 @@ def _find_module(self, id: str, use_typeshed: bool) -> ModuleSearchResult:
 
         if approved_stub_package_exists(id):
             return ModuleNotFoundReason.APPROVED_STUBS_NOT_INSTALLED
-        elif found_possible_third_party_missing_type_hints:
+        if found_possible_third_party_missing_type_hints:
             return ModuleNotFoundReason.FOUND_WITHOUT_TYPE_HINTS
-        else:
-            return ModuleNotFoundReason.NOT_FOUND
+        return ModuleNotFoundReason.NOT_FOUND
 
     def find_modules_recursive(self, module: str) -> list[BuildSource]:
         module_path = self.find_module(module, fast_path=True)

diff --git a/test-data/unit/check-modules.test b/test-data/unit/check-modules.test
@@ -3146,8 +3146,13 @@ main:1: note: (or run "mypy --install-types" to install all missing stub package
 main:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
 main:2: error: Library stubs not installed for "bleach.abc"
 
-[case testMissingSubmoduleOfInstalledStubPackageIgnored]
+[case testMissingSubmoduleOfInstalledStubPackageIgnored-xfail]
 # flags: --ignore-missing-imports
+
+# TODO: testMissingSubmoduleOfInstalledStubPackageIgnored was regressed in
+# https://github.com/python/mypy/pull/15347 but didn't cause failures because we don't have a
+# package path in this unit test
+
 import bleach.xyz
 from bleach.abc import fgh
 [file bleach/__init__.pyi]