Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove [X.Y] from the backport commit message #38

Closed
Mariatta opened this issue Oct 18, 2017 · 0 comments · Fixed by #39
Closed

Remove [X.Y] from the backport commit message #38

Mariatta opened this issue Oct 18, 2017 · 0 comments · Fixed by #39

Comments

@Mariatta
Copy link
Member

[X.Y] should be in the PR title but not in the backport commit message.

Not sure yet if this is for miss-islington or cherry-picker 😅
Writing it down somewhere before I forgot about the issue.
Mariatta added a commit to Mariatta/core-workflow that referenced this issue Oct 19, 2017
@Mariatta
cherry_picker: add a flag if backport commit msg should be prefixed
81b94d8 
Keep the existing functionality that by default the backport commit
message will be prefixed with [X.Y].

Part one for fixing python/miss-islington#38
@Mariatta Mariatta mentioned this issue Oct 19, 2017
Merged
Mariatta added a commit to python/core-workflow that referenced this issue Oct 19, 2017
@Mariatta
cherry_picker: add a flag if backport commit msg should be prefixed (G…
6a16bf2 
…H-193)

Keep the existing functionality that by default the backport commit
message will be prefixed with [X.Y].

Part one for fixing python/miss-islington#38
Mariatta added a commit to Mariatta/core-workflow that referenced this issue Oct 19, 2017
@Mariatta
cherry_picker: Prefix the pull request title if the commit msg doesn'…
2287914 
…t include it

Part two for fixing python/miss-islington#38
@Mariatta Mariatta mentioned this issue Oct 19, 2017
Merged
Mariatta added a commit to python/core-workflow that referenced this issue Oct 19, 2017
@Mariatta
cherry_picker: Prefix the pull request with backport branch (GH-195)
64218b9 
Prefix the Pull Request title with backport branch if it wasn't in the commit message.

Part two for fixing python/miss-islington#38
Mariatta added a commit to Mariatta/miss-islington that referenced this issue Oct 19, 2017
@Mariatta
Don't prefix the commit message with branch number.
94de79d 
Only add the branch prefix to the PR title.

Use cherry_picker v0.2.4

Closes python#38
@Mariatta Mariatta mentioned this issue Oct 19, 2017
Merged
Mariatta added a commit that referenced this issue Oct 19, 2017
@Mariatta
Don't prefix the commit message with branch number. (GH-39)
bb29f17 
Only add the branch prefix to the PR title.

Use cherry_picker v0.2.4

Closes #38
@Mariatta Mariatta mentioned this issue Sep 14, 2018
Closed
@Mariatta Mariatta mentioned this issue Sep 25, 2018
Closed
Mariatta added a commit to python/cherry-picker that referenced this issue May 30, 2019
@Mariatta
cherry_picker: add a flag if backport commit msg should be prefixed (…
9456b48 
…GH-193)

Keep the existing functionality that by default the backport commit
message will be prefixed with [X.Y].

Part one for fixing python/miss-islington#38
Mariatta added a commit to python/cherry-picker that referenced this issue May 30, 2019
@Mariatta
cherry_picker: Prefix the pull request with backport branch (GH-195)
2b7567d 
Prefix the Pull Request title with backport branch if it wasn't in the commit message.

Part two for fixing python/miss-islington#38
@Mariatta Mariatta mentioned this issue Nov 8, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't prefix the commit message with branch number. Mariatta/miss-islington
1 participant
@Mariatta