Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impoting zipp takes between 2-4 ms on my machine, which is at least 10% of overall import time of the
importlib_metadata
package (depending on Python version). Since this package is only used in a single code path it makes sense to defer it.To estimate the cost of repeatedly calling
import zipp
I ran(this is with cpython main branch)
Since this is in a codepath that reads a zipfile from disk, this overhead is negligible.