Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the Polish translation in the language switcher #237

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

StanFromIreland
Copy link
Contributor

I believe this is all that is necessary. If there is much more to be done I can close my PR and let someone who knows the config better do this.

@hugovk
Copy link
Member

hugovk commented Dec 27, 2024

Here's what's needed before adding to the switcher: https://peps.python.org/pep-0545/#add-translation-to-the-language-switcher

As soon as the translation hits:

  • 100% of bugs.html with proper links to the language repository issue tracker.
  • 100% of tutorial.
  • 100% of library/functions (builtins).

the translation can be added to the language switcher.

At least https://docs.python.org/pl/3/library/functions.html still has quite a bit of English in it.

@StanFromIreland
Copy link
Contributor Author

@hugovk Its weird those bits cannot be translated for some reason. They don't show up in transifex and the progress % is 100%.
image

I will look in to it.

@StanFromIreland
Copy link
Contributor Author

@hugovk I see, I translated those today, it will be updated around midnight If i remember correctly! Everything that is required is complete :)

@hugovk
Copy link
Member

hugovk commented Dec 27, 2024

Great, let's check-in tomorrow :)

cc @m-aciek FYI

@StanFromIreland
Copy link
Contributor Author

@hugovk It was built at 6:20 (quite an odd hour) today. The newest build has everything that is required by PEP545 translated.

@AA-Turner
Copy link
Member

AA-Turner commented Dec 28, 2024

@StanFromIreland in the spam.ham example, 'sausage' is translated in the code block but not in the inline code -- is this intentional?

https://docs.python.org/pl/3/library/functions.html#import__


Z drugiej strony, instrukcja from spam.ham import eggs, sausage as saus skutkuje

_temp = __import__('spam.ham', globals(), locals(), ['jajka', 'kielbasa'], 0)
jajka = _temp.jajka
kielbasa = _temp.kielbasa

A

@StanFromIreland
Copy link
Contributor Author

@AA-Turner It has been fixed.

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've spot-checked the tutorial, and confirmed that bugs.html and library/functions.html visually seem fully translated. The transifex project also reports 100% completion for the relevant .po files.

Congratulations @m-aciek, @StanFromIreland, and all of the other translators!

A

@AA-Turner AA-Turner changed the title Add Polish Translation to Switcher Enable the Polish translation in the language switcher Dec 28, 2024
@AA-Turner AA-Turner merged commit e4a8aff into python:main Dec 28, 2024
5 checks passed
@StanFromIreland StanFromIreland deleted the patch-2 branch December 28, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants