Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit checks #87

Merged
merged 6 commits into from
Sep 22, 2023
Merged

Add pre-commit checks #87

merged 6 commits into from
Sep 22, 2023

Conversation

egeakman
Copy link
Contributor

@egeakman egeakman commented Sep 21, 2023

  • Add pre-commit checks
  • Add lint action
  • Fix pre-commit and sphinx-lint complaints

📚 Documentation preview 📚: https://docs-community--87.org.readthedocs.build/en/87/

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a few suggestions :)

.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@egeakman
Copy link
Contributor Author

This PR got a little big in terms of file count. Should I open a seperate PR for the fixes after this one?

cc: @hugovk

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR got a little big in terms of file count. Should I open a seperate PR for the fixes after this one?

No, this is fine, there's not too many and they're small changes.

docs/monthly-meeting/2023-02.md Outdated Show resolved Hide resolved
.github/workflows/lint.yaml Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <[email protected]>
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hugovk hugovk merged commit 8bd026e into python:main Sep 22, 2023
2 checks passed
@egeakman egeakman deleted the pre-commit branch September 22, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants