-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-94808: add tests covering PySequence_{Set,Del}Slice
#99123
Conversation
…cpython into cover-pysequence-slice
Lib/test/test_capi.py
Outdated
# Immutable sequences must raise: | ||
((1, 2, 3, 4), 1, 3, (8, 9)), | ||
('abcd', 1, 3, 'xy'), | ||
# Not a sequnce: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: sequnce
PySequence_{Set,Del}Slice
PySequence_{Set,Del}Slice
Thanks @sobolevn for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
…nGH-99123) (cherry picked from commit c5c4077) Co-authored-by: Nikita Sobolev <[email protected]>
GH-99133 is a backport of this pull request to the 3.11 branch. |
(cherry picked from commit c5c4077) Co-authored-by: Nikita Sobolev <[email protected]>
|
I've seen the buildbot failure. Going to monitor other builds: if they have the same problem, I will fix it. Thanks for the merge! |
These two method were not covered:
I haven't covered
null_error();
case, because it is impossible to reach from python code.And it is also quite trivial not to bother writing its own C-level tests.